-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCALDQM: Update DigiTask for 2018 HE (10_1_X backport) #22972
HCALDQM: Update DigiTask for 2018 HE (10_1_X backport) #22972
Conversation
A new Pull Request was created by @DryRun (David Yu) for CMSSW_10_1_X. It involves the following packages: DQM/HcalCommon @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
please test |
The tests are being triggered in jenkins. |
This PR looks needed to fix a problem reported in prompt RECO, see the thread https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1870.html @DryRun thanks for the fast reaction, this PR was not highlighted as crucial for data taking, and since its master version entered into CMSSW_10_2_0_pre2 that is still under validation, I was waiting for the outcome of that check to integrate it into CMSSW_10_1_X. At this point this is becoming more a fix, but I would like to understand what is causing the crash and why this did not appear so far |
@dmitrijus @jfernan2 @schneiml BTW I understand this is running in online DQM already? |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Backport of #22724 to 10_1_X (the original PR was intended for 10_1_X, but was merged in 10_2_X).
Updates HCALDQM DigiTask for 2018 HE. A number of plots were not filled for HEP17 last year because it would have mixed QIE8 and QIE11 digis; QIE11-specific plots were created in QIE11Task. Now that HE==QIE11, I integrated the plots of interest from QIE11Task to DigiTask.
I also included one small bug fix for LaserTask: with the 2018 HE, the range for the laser signal has to be increased.
#22971 should be merged first.